Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add maintainer docs as per TDR 95 #1903

Merged
merged 6 commits into from
Feb 17, 2022
Merged

docs: Add maintainer docs as per TDR 95 #1903

merged 6 commits into from
Feb 17, 2022

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Feb 15, 2022

Summary

  • Add for_maintainers.md doc
  • Update for_trussels.md doc accordingly
  • Make "Active Maintainers" TBD on README as we start rotating responsibilities
  • Update CODEOWNERS to remove non-trussels
  • Move pre-release docs to its own file to have less content on the main README

@haworku haworku requested a review from jim February 15, 2022 21:59
brandonlenz
brandonlenz reviewed Feb 16, 2022
View reviewed changes
Copy link
Contributor

@brandonlenz brandonlenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haworku for all of this!

I noticed one small grammar thing while reading through. I'm otherwise good to approve (knowing I'll have to re-approve if a change is made anyways).

I don't know if this is something we want to make sure several folks take a look at too, so if it does need to stay open for a little bit and ends up getting stale, let me know and i can also re-approve in that case.

docs/for_trussels.md Outdated Show resolved Hide resolved
suzubara
suzubara previously approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@suzubara suzubara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very exciting!

docs/for_trussels.md Outdated Show resolved Hide resolved
docs/for_trussels.md Outdated Show resolved Hide resolved
@haworku @brandonlenz
Update docs/for_trussels.md
5388424 
Co-authored-by: Brandon Lenz <brandonalenz@gmail.com>
haworku and others added 2 commits February 16, 2022 15:32
@haworku
Update docs/for_trussels.md
529c1e1 
Co-authored-by: Suzanne Rozier <suz@truss.works>
@haworku
Update docs/for_trussels.md
44969a6 
Co-authored-by: Suzanne Rozier <suz@truss.works>
@haworku haworku changed the title Add maintainer docs as per TDR 95 docs: Add maintainer docs as per TDR 95 Feb 16, 2022
brandonlenz
brandonlenz approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@brandonlenz brandonlenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved!

@haworku haworku merged commit ad9bb44 into main Feb 17, 2022
@haworku haworku deleted the hw-maintainer-readme branch February 17, 2022 15:57
@kimallen kimallen mentioned this pull request Feb 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzubara suzubara suzubara approved these changes

@brandonlenz brandonlenz brandonlenz approved these changes

@jim jim Awaiting requested review from jim

@gidjin gidjin Awaiting requested review from gidjin

@sarboc sarboc Awaiting requested review from sarboc

@ahobson ahobson Awaiting requested review from ahobson

@SirenaBorracha SirenaBorracha Awaiting requested review from SirenaBorracha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haworku @suzubara @brandonlenz @trussworks-infra-zz