feat: Accept Accordion headingLevel in items prop #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimallen
requested review from
suzubara,
gidjin,
haworku,
ahobson,
brandonlenz and
SirenaBorracha
as code owners
kimallen
changed the title
kimallen
changed the title
brandonlenz
reviewed
Feb 17, 2022
| @@ -379,4 +379,119 @@ describe('Accordion component', () => { | |||
| ) | |||
| }) | |||
| }) | |||
| describe('custom headingLevel for AccordionItems', () => { | |||
| it('passes on the headingLevel', () => { | |||
| const customTestItems: AccordionItemProps[] = [ | |||
There was a problem hiding this comment.
For other potential reviewers:
AccordionItemProps needed to be renamed (from AccordianItem) so that it could be exported without conflict and used here so that the type inference on headingLevel would match instead of just being string which caused type errors
brandonlenz
reviewed
Feb 17, 2022
brandonlenz
previously approved these changes
Feb 17, 2022
|
Looking at Happo diffs, it looks like they're all IE, on all components. Something about the margin or screen size: Happo usually issues a warning when something like that happens, but i don't see one. Still I'm inclined to approve that since it appears to be an IE issue or some update with happo runners on IE, not related to these changes. |
…n-headinglevel-prop-1904' into kma-accept-accordion-headinglevel-prop-1904
brandonlenz
approved these changes
Feb 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows the Accordion component to accept any heading level. Previously, it was fixed at
h4. For backwards compatibility, the default ish4.Related Issues or PRs
closes #1904
How To Test
To test, one can try running storybook locally and adding a
headingLevelprop to an item initemsAccordion prop of anything other than the defaulth4.