Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add form library examples to example app #203

Closed
suzubara opened this issue May 26, 2020 · 4 comments
Closed

[feat] Add form library examples to example app #203

suzubara opened this issue May 26, 2020 · 4 comments
Labels
type: example Example implementations of ReactUSWDS, such as Storybook or kitchen sink app

Comments

@suzubara
Copy link
Contributor

Does your feature request relate to a specific USWDS feature?
No

Is your feature request related to a problem? Please describe.
This feature will demonstrate how to use ReactUSWDS form components integrated with common React form libraries.

Describe the solution you'd like
Add the following to the /example application:

  • formik
  • react-hook-form

Additional context
Initial discussion: #77

@suzubara suzubara added the type: example Example implementations of ReactUSWDS, such as Storybook or kitchen sink app label May 26, 2020
@haworku haworku self-assigned this Jul 30, 2020
@haworku
Copy link
Contributor

haworku commented Jul 30, 2020

Already started to do this in #351 . Can add a react-hook-form example next.

@haworku haworku removed their assignment Dec 7, 2020
@haworku
Copy link
Contributor

haworku commented Dec 28, 2020

@suzubara do we still think further work here is needed? I am feeling like formik examples are enough for now until we have concrete examples of someone struggling with integrating with some other form library.

@suzubara
Copy link
Contributor Author

suzubara commented Feb 9, 2021

@haworku I do think it would be worth continuing to flesh these out, mostly as a proof of concept but also as testing grounds as we build more complex components such as ComboBox & DatePicker to ensure they expose the necessary props in order to integrate. I can update the issue to reflect a more defined set of requirements.

@haworku
Copy link
Contributor

haworku commented Nov 18, 2022

No more example app, no need for this ticket.

@haworku haworku closed this as completed Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: example Example implementations of ReactUSWDS, such as Storybook or kitchen sink app
Projects
None yet
Development

No branches or pull requests

2 participants