Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Accordion component should support single selectable section behavior by default #207

Closed
duncan-truss opened this issue May 27, 2020 · 1 comment · Fixed by #922
Closed
Assignees
Labels
good first issue Good for newcomers type: breaking This introduces breaking changes and will require a major version increase type: feature New feature or request

Comments

@duncan-truss
Copy link
Contributor

duncan-truss commented May 27, 2020

Does your feature request relate to a specific USWDS feature?
This is an enhancement to the existing Accordion component https://designsystem.digital.gov/components/accordion/. The current implementation defaults to multiselectable behavior where multiple sections can be open at once. However in the USWDS library the default behavior is expanding one section will collapse all others and multiselectable is opt in.

Is your feature request related to a problem? Please describe.
No it is just another component feature of the current spec that someone may want.

Describe the solution you'd like
To align with the behavior of USWDS make multiselectable an attribute/prop set to false by default.

Additional context

From a Slack conversation, the original implementation was made for a project that only needed the multiselectable behavior

@duncan-truss duncan-truss changed the title [feat] [feat] Accordion component should support single selectable section behavior by default May 27, 2020
@duncan-truss duncan-truss added the type: feature New feature or request label May 27, 2020
@haworku haworku assigned haworku and unassigned haworku Jul 30, 2020
@suzubara suzubara added the good first issue Good for newcomers label Feb 2, 2021
@SirenaBorracha SirenaBorracha changed the title [feat] Accordion component should support single selectable section behavior by default feat: Accordion component should support single selectable section behavior by default Feb 19, 2021
@SirenaBorracha SirenaBorracha changed the title feat: Accordion component should support single selectable section behavior by default [feat] Accordion component should support single selectable section behavior by default Feb 19, 2021
@SirenaBorracha
Copy link
Contributor

^^ I accidentally updated the title here and not in my PR

@suzubara suzubara added this to the v2 milestone Feb 19, 2021
@suzubara suzubara removed this from the v2 milestone Apr 12, 2021
@suzubara suzubara added the type: breaking This introduces breaking changes and will require a major version increase label Apr 12, 2021
@haworku haworku closed this as completed Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type: breaking This introduces breaking changes and will require a major version increase type: feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants