Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add defaultValue prop to Search component #2211

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

gidjin
Copy link
Contributor

@gidjin gidjin commented Oct 28, 2022

PR to merge PR #2207 from @1Maria

Summary

Related Issues or PRs

closes #2206

How To Test

Screenshots (optional)

@gidjin gidjin requested a review from a user October 28, 2022 21:03
@gidjin gidjin requested a review from rogeruiz as a code owner October 28, 2022 21:03
@gidjin gidjin changed the title Add defaultValue prop to Search component feat: Add defaultValue prop to Search component Oct 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2022

Warnings
⚠️ This PR does not include changes to storybook, even though it affects component code.

Generated by 🚫 dangerJS against 3351364

@gidjin gidjin changed the title feat: Add defaultValue prop to Search component fix: Add defaultValue prop to Search component Oct 28, 2022
@1Maria
Copy link
Contributor

1Maria commented Oct 31, 2022

Is it possible for me to be listed as a co-contributor on this PR?

@rogeruiz
Copy link
Contributor

hey @1Maria it looks like we don't have a good email address for you to be able to give you proper attribution. Is there an email address you'd like for us to use in order to make sure that your username and icon show up in the GH interface?

The following was extracted from the .patch functionality of GitHub at this URL: https://github.com/trussworks/react-uswds/pull/2211.patch

From d8d4bc32b8b17466b21c1334ab7f67c10e2f14c0 Mon Sep 17 00:00:00 2001
From: Maria <email_address>
Date: Wed, 19 Oct 2022 22:05:49 -0400
Subject: [PATCH] Add defaultValue prop to Search component

@rogeruiz
Copy link
Contributor

rogeruiz commented Oct 31, 2022

@1Maria a no-reply email is appropriate here as those are generated by GitHub. I'll post the documentation on how to generate those shortly.

=> GitHub Setting your commit email address

brandonlenz
brandonlenz previously approved these changes Oct 31, 2022
@1Maria
Copy link
Contributor

1Maria commented Oct 31, 2022

@rogeruiz Thank you! My email is 8730830+1Maria@users.noreply.github.com

Copy link
Contributor

@rogeruiz rogeruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🌈

thanks @gidjin for giving @1Maria proper credit here.

@1Maria
Copy link
Contributor

1Maria commented Nov 8, 2022

yes, thank you!

@gidjin gidjin merged commit 6ad525b into main Nov 8, 2022
@gidjin gidjin deleted the 1maria-defaultValueInSearchComponent-2206 branch November 8, 2022 23:45
@gidjin gidjin mentioned this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fix] Search component should support default value
5 participants