docs(example-app): Example app UI #202 #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzubara
added
the
type: example
suzubara
force-pushed
the
sr-example-app-ui-202
branch
from
ab72e3a
to
73f7ead
Compare
|
note: I ended up using react-router instead of hookrouter because I ran into some basic bugs with hookrouter and decided it would be better to use a more common library. I still don't love react-router but it feels like the lesser evil. |
|
|
Suggestion: edit dangerfile to ignore changes in |
haworku
approved these changes
Jun 9, 2020
eamahanna
approved these changes
Jun 11, 2020
|
Another option: could we have a script to run example app that does yarn build and then starts up app from |
suzubara
force-pushed
the
sr-example-app-ui-202
branch
from
8bffe2f
to
3bcf44c
Compare
eamahanna
approved these changes
Jun 15, 2020
haworku
approved these changes
Jun 15, 2020
haworku
added a commit
that referenced
this pull request
Jun 15, 2020
commit 1054469 Author: Emily Mahanna <56279459+eamahanna@users.noreply.github.com> Date: Mon Jun 15 10:40:45 2020 -0800 feat(example app): add modals page example 204 (#250) * WIP Set up basic layout, router * Switch to react-router, add placeholder content * feat(example app): add modals example page * feat(example app): add redux for modals * hook up modals page * feat(example app): add hook modal * fix(modals page): fixes from PR review * fix(modals page): pr update * fix(modals page): remove comment * fix(modals page): add import back in Co-authored-by: Suzanne Rozier <suz@truss.works> commit 832decc Author: Suzanne Rozier <suz@truss.works> Date: Mon Jun 15 13:00:03 2020 -0500 docs(example-app): Example app UI #202 (#237) * WIP Set up basic layout, router * Switch to react-router, add placeholder content * Add docs and commands for running the example app
Merged
haworku
pushed a commit
that referenced
this pull request
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bootstraps basic UI for the example application, including routing with React Router.
Related Issues or PRs
Closes #202
How To Test
Navigate to the
/exampledirectory, install dependencies (yarn install), and start the app (yarn start). Verify you can view the app, which currently just has two pages that are mostly empty (home & examples).Screenshots (optional)