Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set alternative text on SVG img icon in menu close button #2500

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix: Set alternative text on SVG img icon in menu close button #2500

merged 1 commit into from
Jul 17, 2023

Conversation

sawyerh
Copy link
Contributor

@sawyerh sawyerh commented Jul 17, 2023

Summary

<svg> elements with an img role must have an alternative text: https://dequeuniversity.com/rules/axe/4.6/svg-img-alt?application=msftAI

Related Issues or PRs

This issue was introduced in #2411, and began failing a11y tests in our project when 5.0.0 was released.

How To Test

  1. Open the NavCloseButton Storybook page
  2. Change your viewport size so the button shows
  3. Run an accessibility scanner like https://accessibilityinsights.io/

Screenshots

Before:

CleanShot 2023-07-17 at 10 32 46@2x

After:

CleanShot 2023-07-17 at 10 34 25@2x

@sawyerh sawyerh requested a review from a user July 17, 2023 17:34
@sawyerh sawyerh changed the title Fix accessibility error on menu Close button fix: Set alternative text on SVG img icon in menu close button Jul 17, 2023
@sawyerh sawyerh mentioned this pull request Jul 17, 2023
Merged
1 task
@brandonlenz brandonlenz merged commit ebdca5b into trussworks:main Jul 17, 2023
@github-actions github-actions bot mentioned this pull request Jul 17, 2023
Merged
@brandonlenz
Copy link
Contributor

@sawyerh thanks for the PR!

I wanted to test out our new implementation of release-please, so your change is already available in 5.1.1

@brandonlenz
Copy link
Contributor

@all-contributors please add @sawyerh for bug

@allcontributors
Copy link
Contributor

@brandonlenz

We had trouble processing your request. Please try again later.

@sawyerh sawyerh deleted the sawyerh/close-svg-a11y branch July 17, 2023 20:17
@brandonlenz brandonlenz mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonlenz brandonlenz brandonlenz approved these changes

@gidjin gidjin Awaiting requested review from gidjin

@haworku haworku Awaiting requested review from haworku

@ahobson ahobson Awaiting requested review from ahobson

@SirenaBorracha SirenaBorracha Awaiting requested review from SirenaBorracha

@rogeruiz rogeruiz Awaiting requested review from rogeruiz

@jcbcapps jcbcapps Awaiting requested review from jcbcapps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sawyerh @brandonlenz