-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve character count component's SR experience #2550
Conversation
Yeah, still investigating why Voiceover is not reading the updates out here. I can see it working here in the USWDS preview: https://federalist-3b6ba08e-0df4-44c9-ac73-6fc193b0e19c.sites.pages.cloud.gov/preview/uswds/uswds/jm-a11y-character-count/iframe.html?args=&id=components-form-inputs-character-count--character-count&viewMode=story |
@werdnanoslen I pushed an update that should now work with VoiceOver. Let me know if you can test it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 rec, 1 question. Lemme know if you need re-approval
if (srMessageRef.current) srMessageRef.current.textContent = message | ||
}, 1000) | ||
return () => clearTimeout(timer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Does a useState/setState not work for Voiceover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not! Very weird that it didn't. It did work with every other SR I tested.
@werdnanoslen Ah sorry I need another happo approval! |
Summary
Character count includes a brief pause on input before announcing the status.
Related Issues or PRs
Closes #2509
Related PR in USWDS repo: uswds/uswds#4976
How To Test
The SR message for the number of characters left works in:
Screenshots (optional)