feat(NavList): use type prop, deprecate boolean types #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahobson
requested review from
gidjin,
haworku,
sarboc,
suzubara and
tinyels
as code owners
haworku
approved these changes
Jun 17, 2020
ahobson
force-pushed
the
adh-navlist-prop-enums-234
branch
from
f446b45
to
820b01e
Compare
Merged
haworku
pushed a commit
that referenced
this pull request
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Convert from boolean props to
typeprop enumRelated Issues or PRs
How To Test
Look at story and test changes
Screenshots (optional)