Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lint warnings #319

Merged
merged 3 commits into from
Jul 15, 2020
Merged

fix: lint warnings #319

merged 3 commits into from
Jul 15, 2020

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Jul 14, 2020

Summary

Quick cleanup before next release (1.7.0).

How To Test

  • yarn lint should run without warnings

@haworku haworku requested a review from ahobson July 14, 2020 19:53
ahobson
ahobson approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@ahobson ahobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this work

@haworku haworku merged commit 95a12a3 into main Jul 15, 2020
@haworku haworku deleted the hw-fix-lint-warnings branch July 15, 2020 17:43
@haworku haworku mentioned this pull request Jul 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahobson ahobson ahobson approved these changes

@gidjin gidjin Awaiting requested review from gidjin

@sarboc sarboc Awaiting requested review from sarboc

@suzubara suzubara Awaiting requested review from suzubara

@tinyels tinyels Awaiting requested review from tinyels

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haworku @ahobson