Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Update Table to USDWS 2.10.0 implementation #991

Closed
brandonlenz opened this issue Mar 5, 2021 · 0 comments · Fixed by #1110
Closed

[feat] Update Table to USDWS 2.10.0 implementation #991

brandonlenz opened this issue Mar 5, 2021 · 0 comments · Fixed by #1110
Assignees
Labels
status: hold merge This indicates not to merge the PR as there is a development dependency/other reason to hold off. type: feature New feature or request
Milestone

Comments

@brandonlenz
Copy link
Contributor

brandonlenz commented Mar 5, 2021

Does your feature request relate to a specific USWDS component?

Table

What USWDS Version is this feature present in?

2.10.0

Context
USWDS 2.10.0 Added several new table variations for mobile and data friendly display:

  • scrollable
  • striped
  • compact
  • stacked
  • stacked-header

Describe the solution you'd like

Add new props to implement the new classes/style variations. Something like below:

scrollable?: boolean //default false
striped?: boolean //default false
compact?: boolean //default false
stackedStyle?: 'none' | 'default' | 'headers' // default 'none'

I combined the stacked and stacked-header modifiers into a single prop because the two appear to be mutually exclusive. Implementers will use it as follows:

<Table stackedStyle="default"

OR

<Table stackedStyle="headers" ...

Add storybook stories and unit tests for the different variations and verify the existing variations continue to behave as they should.

This might be a good candidate to add a storybook controls demo story 🤔

Describe alternatives you've considered

If there is a more effective and intuitive way to provide access to these table styles, feel free to go that route! Especially considering the stacked-header implementation. There may be a neater way to handle that.

@brandonlenz brandonlenz added the type: feature New feature or request label Mar 5, 2021
@brandonlenz brandonlenz added this to the USWDS 2.10.0 milestone Mar 5, 2021
@SirenaBorracha SirenaBorracha self-assigned this Apr 9, 2021
@SirenaBorracha SirenaBorracha added the status: hold merge This indicates not to merge the PR as there is a development dependency/other reason to hold off. label Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: hold merge This indicates not to merge the PR as there is a development dependency/other reason to hold off. type: feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants