[Bug]: OpenID Connect Button missing on login page

[officebluesource]

部署方式 | How to Deploy

使用一键部署脚本 | Using zealot-docker on-click install (Default)

部署版本 | Version

5.3.5 and 5.3.6

Git 哈希值 (长度 40)| Git Ref (40 length)

dont know

反代服务 | Reverse Proxy

ngnix

HTTPS 证书类型 | HTTPS(SSL)

可受信任的证书 Verified SSL

已阅读文档 | Read the document

• 已阅读 | Yes

描述 | Description

Hi,
after update from 5.3.3 to 5.3.6 the button "Sign in with OpenID" is missing on the login page.
5.3.5 has the same issue, 5.3.4 works

regards

问题日志 | Relevant log output

No response

[welcome]

感谢你提交的问题或反馈，我会在有时间的时候回复在此期间你可以看看之前被解决的反馈说不定有你需要的答案。
Thanks for opening this issue, a maintainer will get back to you shortly!

[icyleaf]

Relates to #1613, and it had been fixed in 5.3.6. demo site works.

[officebluesource]

not on my side :(

[icyleaf]

Do you disable it either in Setting page or enviroment variable (OIDC_ENABLED=false)?

[officebluesource]

no, is enabled in both gui and the env-file

[icyleaf]

So wired, do you try restart the zealot service?

[officebluesource]

yeah, docker restart / host server restart, no change

[icyleaf]

Sorry, I've checked all the possible locations and found no issues at all. Moreover, the version you've screenshotted above is the nightly version, which is the latest development version and does not have the issue you mentioned. Or is there any private communication method to help you find the specific problem?

[officebluesource]

thanks for your effort! I will try to create a new instance with a fresh postgres database. this will work

[officebluesource]

Hi @icyleaf
I set up a test version 5.3.6 with an empty database today, and the OIDC login works without any issues. So it's either an issue with the upgrade/downgrade of Rack between the versions or some problem with the data in the Postgres database.
Is there any data related to OIDC stored in the database?

[icyleaf]

Thanks for testing feedback.

Is there any data related to OIDC stored in the database?

It will store the OIDC setting if configure it from Setting page. dig the data from DB:

SELECT FROM settings WHERE var = 'oidc'

[officebluesource]

@icyleaf I just run through the whole upgrade process with a fresh test-instance (no data, just the initial setup database with docker-compose run --rm zealot run_upgrade )

starting with 5.3.0 -> 5.3.1 -> 5.3.2 -> 5.3.3 -> 5.3.4. Everything good, OIDC Button is there.
then
upgrade to 5.3.5 -> OIDC Button gone -> upgrade 5.3.6 -> still missing

Fresh installation of 5.3.6 works, only upgrade from 5.3.5 and earlier seems to be faulty.
Something is breaking in the upgrade process

[icyleaf]

A very detailed analysis process, I checked the changelog and roughly understood the issue. In version 5.3.5, a breaking change was made which means that while the registration feature was disabled, all third-party logins would also be disabled (hiding the enabled authorization button).

Perhaps these two logics should be set as independent switches.

[officebluesource]

true that! I can confirm this behaviour. When I set ZEALOT_REGISTER_ENABLED to true, the OIDC button appears.
Unfortunately, this is not a solution for us, as we don't want user registration. Maybe you can seperate this logic in one of the next versions :)

Thanks!

[icyleaf]

This issue has been reported by other users before. After careful consideration, I have decided to retract this logic and disable the built-in registration feature. This will not affect third-party authorization logins. I will supplement a complete RFC later.

[icyleaf]

Relates to #1671