Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't redux be part of the dependencies in package.json? #37

Open
tkrugg opened this issue Jan 14, 2017 · 2 comments
Open

Shouldn't redux be part of the dependencies in package.json? #37

tkrugg opened this issue Jan 14, 2017 · 2 comments

Comments

@tkrugg
Copy link

tkrugg commented Jan 14, 2017

No description provided.

@juanlizarazo
Copy link

Definitively.
It used to be part of package.json. Now it's gone.

ERROR in ./src/store/configureStore.dev.js
Module not found: Error: Cannot resolve module 'redux' in /home/juan/dev/simple-redux-boilerplate/src/store
 @ ./src/store/configureStore.dev.js 3:13-29

ERROR in ./src/containers/App.js
Module not found: Error: Cannot resolve module 'redux' in /home/juan/dev/simple-redux-boilerplate/src/containers
 @ ./src/containers/App.js 25:13-29

ERROR in ./src/reducers/index.js
Module not found: Error: Cannot resolve module 'redux' in /home/juan/dev/simple-redux-boilerplate/src/reducers
 @ ./src/reducers/index.js 7:13-29

ERROR in ./~/react-redux/lib/utils/wrapActionCreators.js
Module not found: Error: Cannot resolve module 'redux' in /home/juan/dev/simple-redux-boilerplate/node_modules/react-redux/lib/utils
 @ ./~/react-redux/lib/utils/wrapActionCreators.js 6:13-29
Child html-webpack-plugin for "index.html":
         Asset     Size  Chunks       Chunk Names
    index.html  1.44 MB       0       
    chunk    {0} index.html 541 kB [rendered]
        [0] ./~/html-webpack-plugin/lib/loader.js!./index.html 767 bytes {0} [built]
        [1] ./~/lodash/lodash.js 540 kB {0} [built]
        [2] (webpack)/buildin/module.js 251 bytes {0} [built]

@tkrugg Add it back locally on your project.

I'd suggest you to create a PR too to fix this but this project hasn't been actively maintained or opened to contributors yet (@tsaiDavid please add contributors and don't let this project die!). There's PR's dating back to almost 1 year ago as outstanding issues as well.

@nitindev111
Copy link

yes.Redux should be part of package.json.Kindly fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants