Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ModelFitting): now support line fitting #13

Merged
merged 2 commits into from
Dec 16, 2019
Merged

feat(ModelFitting): now support line fitting #13

merged 2 commits into from
Dec 16, 2019

Conversation

tsteffek
Copy link
Owner

Given a cloud of points this new algorithm is able to fit several lines
utilizing point proximity into the data.

tsteffek added 2 commits December 16, 2019 15:57
Given a cloud of points this new algorithm is able to fit several lines
utilizing point proximity into the data.
@tsteffek tsteffek merged commit 038e1c3 into dev Dec 16, 2019
@tsteffek tsteffek deleted the line-fitting branch December 16, 2019 16:05
@tsteffek
Copy link
Owner Author

Codecov Report

Merging #13 into dev will increase coverage by 2.88%.
The diff coverage is 96.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev      #13      +/-   ##
============================================
+ Coverage     58.88%   61.77%   +2.88%     
- Complexity       48       52       +4     
============================================
  Files            10       11       +1     
  Lines           270      293      +23     
  Branches         34       40       +6     
============================================
+ Hits            159      181      +22     
  Misses           92       92              
- Partials         19       20       +1
Impacted Files Coverage Δ Complexity Δ
src/main/kotlin/model/Scan2D.kt 72.41% <ø> (ø) 1 <0> (ø) ⬇️
src/main/kotlin/model/geometry/Line.kt 75.86% <100%> (+0.86%) 14 <2> (+3) ⬆️
src/main/kotlin/model/NeighborhoodGraph.kt 90.69% <100%> (+0.45%) 4 <1> (+1) ⬆️
src/main/kotlin/math/Geometry.kt 100% <100%> (ø) 0 <0> (ø) ⬇️
src/main/kotlin/algorithms/ModelFitting.kt 94.73% <94.73%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e3d0b1...447dcbd. Read the comment docs.

@github-actions
Copy link

🎉 This PR is included in version 1.0.0-dev.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant