Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing CoffeeScript suggestions and warnings #25

Open
erikogan opened this issue Sep 28, 2019 · 2 comments
Open

Implementing CoffeeScript suggestions and warnings #25

erikogan opened this issue Sep 28, 2019 · 2 comments

Comments

@erikogan
Copy link
Contributor

erikogan commented Sep 28, 2019

Once I’m done with my PAM module (and I have some free time), I’d like to take a stab at implementing some of the CoffeeScript warnings and suggestions.

My current thought is to leave ZxcvbnMatch as it is, but add a function that takes the ZxcMatch_t list and returns a structure that mimics the warnings and suggestions.

Then I’d probably also add a helper function that provides one call that wraps both functions.

Given that might be a large-ish (but non-invasive) change, I thought it best to clear the work with you before I start.

@tsyrogit
Copy link
Owner

There shouldn't be any problem as you are suggesting a separate function to make the warning/suggestions. Existing users can then continue using the updated library in their current programs without change to their source (but may need to re-compile) and optionally use the added features later.

@erikogan
Copy link
Contributor Author

erikogan commented Oct 7, 2019

Great. That’s exactly why I thought it best to add it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants