Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nix Flake.lock #113

Closed
jeiang opened this issue Apr 16, 2023 · 3 comments · Fixed by #114
Closed

Update Nix Flake.lock #113

jeiang opened this issue Apr 16, 2023 · 3 comments · Fixed by #114

Comments

@jeiang
Copy link
Contributor

jeiang commented Apr 16, 2023

Trying to build using nix fails due to clap's MSRV being 1.64.0, but rustc in nixpkgs from the flake lock being 1.62.1.

Log from nix run github:tobealive/wthrr-the-weathercrab:

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/izcn871i8ms2g9ii09bdh6g4z4snbf0r-source
source root is source
Executing cargoSetupPostUnpackHook
unpacking source archive /nix/store/khx4k10fifgh7jghrm5k2jhby9va30mq-cargo-vendor-dir
Finished cargoSetupPostUnpackHook
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
Executing cargoSetupPostPatchHook
Validating consistency between /build/source//Cargo.lock and /build/cargo-vendor-dir/Cargo.lock
Finished cargoSetupPostPatchHook
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
@nix { "action": "setPhase", "phase": "buildPhase" }
building
Executing cargoBuildHook
++ env CC_x86_64-unknown-linux-gnu=/nix/store/kia8xygy2r9iblwbjrl163j4bpz84wz7-gcc-wrapper-11.3.0/bin/cc CXX_x86_64-unknown-linux-gnu=/nix/store/kia8xygy2r9iblwbjrl163j4bpz84wz7-gcc-wrapper-11.3.0/bin/c++ CC_x86_64-unknown-linux-gnu=/nix/store/kia8xygy2r9iblwbjrl163j4bpz84wz7-gcc-wrapper-11.3.0/bin/cc CXX_x86_64-unknown-linux-gnu=/nix/store/kia8xygy2r9iblwbjrl163j4bpz84wz7-gcc-wrapper-11.3.0/bin/c++ cargo build -j 16 --target x86_64-unknown-linux-gnu --frozen --release
error: package `clap v4.2.1` cannot be built because it requires rustc 1.64.0 or newer, while the currently active rustc version is 1.62.1
@ttytm
Copy link
Owner

ttytm commented Apr 16, 2023

Hey @jeiang,

Thanks for reaching out! Sorry about the inconvenience. If it's not to much of a hassle do you have a chance to submit a fix? Else I'll check into it to coming week 👍

@jeiang
Copy link
Contributor Author

jeiang commented Apr 16, 2023

Yea sure, I can do it (fixed it locally already). I'll make a PR.

Also, some of the tests (specifically modules::localization::tests::translate_string and modules::location::tests::geolocation_response) fail when building because of nix's sandbox. I have some possible fixes for it, should I open a different issue/PR for it?

@ttytm
Copy link
Owner

ttytm commented Apr 17, 2023

That would be awesome. Tyvm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants