Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab renaming in :gui module, branch feature/web-gui #507

Open
fmuratori opened this issue May 28, 2023 · 0 comments
Open

Tab renaming in :gui module, branch feature/web-gui #507

fmuratori opened this issue May 28, 2023 · 0 comments

Comments

@fmuratori
Copy link

The following behaviour is implemented in the branch feature/web-gui in the module :gui

Following the renaming of a Page object, ApplicationImpl automatically generates an Event containing fields such as the old and new name respectively.

Bug:
In the implementation of ApplicationImpl, the resulting observable event provides the old name inside of the new name field.

More specifically, the implementation of file gui/src/commonMain/kotlin/it/unibo/tuprolog/ui/gui/impl/ApplicationImpl.kt at line 53 is:

page.onRename += { handlePageRenaming(it.event.first, it.event.first) }

Fix:

A possible fix to the implementation is shown below:

page.onRename += { handlePageRenaming(it.event.first, it.event.second) }
@fmuratori fmuratori changed the title :gui module tab renaming Tab renaming in :gui module, branch feature/web-gui May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant