Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .bumpversion.cfg file #11

Closed
niketagrawal opened this issue Aug 16, 2024 · 6 comments · Fixed by #13
Closed

Add .bumpversion.cfg file #11

niketagrawal opened this issue Aug 16, 2024 · 6 comments · Fixed by #13
Assignees
Labels
enhancement New feature or request

Comments

@niketagrawal
Copy link

niketagrawal commented Aug 16, 2024

When tudat is bumped to a new dev version, the following actions must happen on tudat-feedstock develop branch:

  • Bump version: this results in bumping of the dev version in recipe/meta.yml and .bumpversion.cfg file
  • Create a tag with the above version
  • Push the tag to tudat-feedstock

Currently, the above operation is being done manually. Automating the bump version operation will synchronize the dev versions of tudat and tudat-ffedstock

@niketagrawal niketagrawal self-assigned this Aug 16, 2024
@niketagrawal niketagrawal added the enhancement New feature or request label Aug 16, 2024
@niketagrawal
Copy link
Author

niketagrawal commented Aug 16, 2024

Changes are being developed and tested in https://github.com/niketagrawal/tudat-feedstock/tree/develop

To do:

  • Add .bumpversion.cfg
  • Modify recipe/meta.yml to correctly bump the version and git_rev numbers using the bumpversion command.
  • Try polling instead of receiving a notification from tudat repository. The latter didn't work due to incorrect/missing token permissions. An alternative to receiving a notification from tudat upon a commit on develop is to poll the tudat repository nightly for new commits on develop branch of tudat.

@niketagrawal niketagrawal changed the title Bump version number on develop branch of tudat-feedstock and create tag when develop branch of tudat has a new commit Bump version number on develop branch and create tag when develop branch of tudat has a new commit Aug 16, 2024
@niketagrawal
Copy link
Author

Done

  • GitHub actions workflow in tudat repository to bump the version in tudat repository when a new commit on dev branch is created
  • GitHub actions workflow in tudat-feedstock that watches for new commits on dev branch of tudat and bumps version in meta.yml

Questions

  • Con of polling on tudat-feedstock: Between subsequent poll intervals, multiple commits might be made on dev branch of tudat. How do bump the version number on feedstock in this case?
  • At what point does the minor or patch version number needs to be updated? The bumpversion command in the workflow will need to be modified then, because by default it bumps the devxx number after the patch.

@niketagrawal
Copy link
Author

niketagrawal commented Aug 30, 2024

The polling based workflow to detect new commits in tudat dev branch has the following cons:

  • Each new commit on tudat will have to wait before the corresponding dev conda package is created
  • Between two consecutive worklfow runs, dev branch of tudat could receive multiple commits.

To do

  • Revert the polling based workflow on tudat-feedstock to dispatch event based workflow so all commits on tudat are sure to trigger a new dev conda package.
  • Create a separate bump version workflow in tudat that will bump the minor version on main when a new commit is made. : Automated workflow for master branch is not needed. It is desired to keep the bump version operation manual on the master branch.

@niketagrawal niketagrawal changed the title Bump version number on develop branch and create tag when develop branch of tudat has a new commit Implement nightly bump version automation workflow Sep 25, 2024
@niketagrawal niketagrawal changed the title Implement nightly bump version automation workflow Bump version and create tag on develop branch when tudatpy has a new dev version Sep 25, 2024
@niketagrawal
Copy link
Author

niketagrawal commented Sep 30, 2024

This issue will get fixed with tudat-team/tudat#232 is closed. A nightly bump version workflow in tudat will be created as part of this isse which will bump version, create tag and push tag to tudat-feedstock.

Tudat-feedstock misses a .bumpversion.cfg and the recipe/meta.yml must be adapted to work with the bumpversion command. These changes will be introduced via a PR.

@niketagrawal
Copy link
Author

niketagrawal commented Oct 3, 2024

Changes in branch https://github.com/tudat-team/tudat-feedstock/tree/11-add-bumpversion-cfg

Creating a draft pull request triggers azure pipelines. They must be manually stopped when the PR containing these changes is being merged to avoid creating a new conda package.

@niketagrawal niketagrawal changed the title Bump version and create tag on develop branch when tudatpy has a new dev version Add bumpversion cfg file Oct 4, 2024
@niketagrawal niketagrawal changed the title Add bumpversion cfg file Bump version and create tag on develop branch when tudatpy has a new dev version Oct 4, 2024
@niketagrawal niketagrawal changed the title Bump version and create tag on develop branch when tudatpy has a new dev version Add .bumpversion.cfg file Oct 7, 2024
@niketagrawal
Copy link
Author

Changes merged in pull request #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment