Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(widget): add offset() to TableState #10

Merged
merged 1 commit into from
Feb 18, 2023
Merged

feat(widget): add offset() to TableState #10

merged 1 commit into from
Feb 18, 2023

Conversation

orhun
Copy link
Member

@orhun orhun commented Feb 12, 2023

Upstream: #481

Description

Add simple getter method to TableState that returns a copy of its offset field.

My motivating case is a program that allows scrolling a Table and an adjacent (related) Paragraph at the same time

Testing guidelines

I don't know that any testing is useful here since it only exposes an existing piece of data.

Checklist

@mindoodoo mindoodoo added the Type: Enhancement New feature or request label Feb 14, 2023
@orhun orhun changed the title Add TableState.offset(&self) -> usize feat(widget): add offset() to TableState Feb 18, 2023
@orhun orhun merged commit 9b7a6ed into master Feb 18, 2023
@orhun orhun deleted the 481/master branch February 18, 2023 02:11
sayanarijit pushed a commit that referenced this pull request Mar 3, 2023
Co-authored-by: Aaron Rennow <arennow@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants