feat(off): allow removing all listeners of all events

just off(name) will remove all "name" listeners; off() with no arguments will reset the store to be empty
tunnckoCoreLabs · Mar 19, 2017 · 095140f · 095140f
1 parent 923391d
commit 095140f
Show file tree

Hide file tree

Showing 7 changed files with 36 additions and 8 deletions.
diff --git a/dist/dush.common.js b/dist/dush.common.js
@@ -124,7 +124,7 @@ function dush () {
      */
 
     on: function on (name, handler, once) {
-      var e = all[name] || (all[name] = []);
+      var e = app.all[name] || (app.all[name] = []);
 
       function func () {
         if (!func.called) {
@@ -217,8 +217,10 @@ function dush () {
       if (handler && all[name]) {
         var fnStr = handler.toString();
         all[name] = all[name].filter(function (func) { return func.sourceString !== fnStr; });
-      } else {
+      } else if (name) {
         all[name] = [];
+      } else {
+        app.all = Object.create(null);
       }
 
       return app

diff --git a/dist/dush.es.js b/dist/dush.es.js
@@ -122,7 +122,7 @@ function dush () {
      */
 
     on: function on (name, handler, once) {
-      var e = all[name] || (all[name] = []);
+      var e = app.all[name] || (app.all[name] = []);
 
       function func () {
         if (!func.called) {
@@ -215,8 +215,10 @@ function dush () {
       if (handler && all[name]) {
         var fnStr = handler.toString();
         all[name] = all[name].filter(function (func) { return func.sourceString !== fnStr; });
-      } else {
+      } else if (name) {
         all[name] = [];
+      } else {
+        app.all = Object.create(null);
       }
 
       return app

diff --git a/dist/dush.umd.js b/dist/dush.umd.js
diff --git a/dist/dush.umd.js.gz b/dist/dush.umd.js.gz
diff --git a/dist/dush.umd.js.map b/dist/dush.umd.js.map