Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoWarn doesn't suppress RA1000 #31

Closed
jnm2 opened this issue Sep 30, 2019 · 1 comment · Fixed by #34
Closed

NoWarn doesn't suppress RA1000 #31

jnm2 opened this issue Sep 30, 2019 · 1 comment · Fixed by #34
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@jnm2
Copy link
Contributor

jnm2 commented Sep 30, 2019 •
edited
Loading

A net35 project that uses System.Data will cause a RA1000 warning. Since there's nothing I can do about this—nothing under my control is misconfigured—I tried acknowledging the warning by adding <NoWarn>RA1000</NoWarn> to the project.

It had no effect since by default the list is passed to csc which has nothing to do with this, but I'm interested in some way of suppressing it. I know that other SDK targets like NuGet stuff respect NoWarn. Is that what should happen here?
@sharwell
Copy link
Member

💭 I think NoWarn needs to be passed to the build task.

@sharwell sharwell added enhancement New feature or request help wanted Extra attention is needed labels Sep 30, 2019
@jnm2 jnm2 mentioned this issue Sep 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Respect NoWarn in project jnm2/ReferenceAssemblyAnnotator
2 participants
@sharwell @jnm2