Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRE in SuppressibleLoggingHelper constructor #76

Closed
jnm2 opened this issue Jan 3, 2020 · 0 comments · Fixed by #77
Closed

NRE in SuppressibleLoggingHelper constructor #76

jnm2 opened this issue Jan 3, 2020 · 0 comments · Fixed by #77
Labels
bug Something isn't working

Comments

@jnm2
Copy link
Contributor

jnm2 commented Jan 3, 2020

Looks like disabledWarnings must be null:

public SuppressibleLoggingHelper(TaskLoggingHelper helper, string requiredPrefix, string disabledWarnings)
{
_helper = helper;
if (string.IsNullOrWhiteSpace(requiredPrefix))
throw new ArgumentException("A required warning prefix must be supplied.", nameof(requiredPrefix));
_requiredPrefix = requiredPrefix;
_disabledWarnings = disabledWarnings
.Split(new[] { ',', ';' }, StringSplitOptions.RemoveEmptyEntries)
.Select(item => item.Trim())
.Where(item => item.StartsWith(requiredPrefix, StringComparison.Ordinal))
.ToImmutableHashSet(StringComparer.Ordinal);
}

@sharwell sharwell added the bug Something isn't working label Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants