Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement Set collection #37

Open
mappum opened this issue Jun 6, 2021 · 1 comment
Open

Reimplement Set collection #37

mappum opened this issue Jun 6, 2021 · 1 comment

Comments

@mappum
Copy link
Contributor

mappum commented Jun 6, 2021

We got rid of it during #36

@mappum
Copy link
Contributor Author

mappum commented Sep 4, 2021

Since keys are limited in length to 256 bytes, the pattern of storing values as keys so they are indexed seems prone to hitting this limit. We could probably approach this by implementing a Set type which uses hashes of the values as store keys, and stores the encoded value in the store value. This is maybe easier to implement on top of EntryMap since it has a similar API but I'm not sure if it all maps 1:1.

Since the ordering would be seemingly random (but still deterministic), it may be a good choice to not even support iteration in order to disincentivize writing code which iterates over too many values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant