Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

including the original protobuf for easier comparison #31

Open
songbinliu opened this issue Sep 18, 2017 · 1 comment
Open

including the original protobuf for easier comparison #31

songbinliu opened this issue Sep 18, 2017 · 1 comment

Comments

@songbinliu
Copy link
Contributor

songbinliu commented Sep 18, 2017 •
edited
Loading

It is important to know the changes of the canonical protobuf definition from sdk team.
Currently, only the generated go code of the protobuf is included in this repos. To know what has been changed, we have to checkout the protobuf definition from sdk team, generate the go code, and then do the comparison. This process is inconvenient and slow.

It would be easier for us to debug when there is a potential protobuf version mismatch between turbo-go-sdk, and the canonical version.
@songbinliu
Copy link
Contributor Author

The canonical protobuf definition is: com.vmturbo.platform.sdk.common/src/main/protobuf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@songbinliu