Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create [table,file]_logging_* columns to azure_storage_account table #428

Closed
Joeturbot opened this issue Dec 28, 2021 · 2 comments · Fixed by #432
Closed

Create [table,file]_logging_* columns to azure_storage_account table #428

Joeturbot opened this issue Dec 28, 2021 · 2 comments · Fixed by #432
Assignees
Labels
enhancement New feature or request

Comments

@Joeturbot
Copy link

Is your feature request related to a problem? Please describe.
As a part of Azure CIS 3, support was added for logging Storage Account Queues and Blobs. The same kind of logging information can be had for SA Tables and Files.

Original CIS ticket: #48

Describe the solution you'd like
Add columns support for table_logging_* and file_logging_* in the azure_storage_account table

Describe alternatives you've considered
Try to pull some data out of the azure_diagnostic_setting table, maybe(?)

Additional context
Slack conversation: https://steampipe.slack.com/archives/C01TFE9SU1F/p1640714129093900

@Joeturbot Joeturbot added the enhancement New feature or request label Dec 28, 2021
@rajlearner17
Copy link
Contributor

@Joeturbot appreciate for helping to respond in slack. We will take a look and take appropriate action.

@bigdatasourav
Copy link
Contributor

As of now, API support is not available for logging SA Tables and Files, for blob and queue we have used https://pkg.go.dev/github.com/tombuildsstuff/giovanni/storage/2019-12-12@v0.15.1 which is a different SDK. In that also API support is not available.

I have added diagnostic_settings column in azure_storage_account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants