Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OpenTelemetry metric names must only contain [A-Za-z0-9_.-] #369

Merged
merged 1 commit into from
Nov 17, 2023
Merged

fix: OpenTelemetry metric names must only contain [A-Za-z0-9_.-] #369

merged 1 commit into from
Nov 17, 2023

Conversation

pdecat
Copy link
Contributor

@pdecat pdecat commented Oct 26, 2023 •
edited
Loading

Without this change, using telemetry fails with:

2023-10-26 10:40:25.998 UTC [TRACE] hub: init telemetry end
2023-10-26 10:40:25.998 UTC [WARN]  hub: init telemetry failed to create hydrateCallsCounter
2023-10-26 10:40:25.998 UTC [1655556] FATAL:  invalid instrument name: steampipe-postgres-fdw/hydrate_calls_total: must only contain [A-Za-z0-9_.-]

@kaidaguerre kaidaguerre merged commit 3bb226f into turbot:main Nov 17, 2023
2 checks passed
@pdecat pdecat deleted the fix/otel_metric_hydrate_calls_total branch November 17, 2023 11:25
kaidaguerre pushed a commit that referenced this pull request Dec 20, 2023
@pdecat @kaidaguerre
fix: OpenTelemetry metric names must only contain [A-Za-z0-9_.-] (#369)
9721b50 
(cherry picked from commit 3bb226f)
@timsutton timsutton mentioned this pull request Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaidaguerre kaidaguerre kaidaguerre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdecat @kaidaguerre