Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Latest" and "Latest LTS" to the "Select Release" combo box #1

Closed
maverick74 opened this issue Jul 29, 2020 · 7 comments
Closed
Labels
enhancement New feature or request
Milestone

Comments

@maverick74
Copy link

Add "Latest" and "Latest LTS" to the "Select Release" combo box so that, this way, one can set it to always live on the Latest LTS release or in the Latest Release, what ever the number might be, and just forget about it as opposed to having to manually change the version every time a new major release is out.

@tushev tushev added the enhancement New feature or request label Jul 29, 2020
@tushev
Copy link
Owner

tushev commented Jul 29, 2020

@maverick74 I think I will implement this in the next release of the updater. However, currently I cannot say when exactly it will be ready.

@tushev tushev added this to the V2 milestone Jul 29, 2020
@maverick74
Copy link
Author

Nice!

Would be cool if it wouldn't take too long :)

@tushev
Copy link
Owner

tushev commented Sep 26, 2020

@maverick74 Version 2, released just now, implements this feature.

You can find more info here: https://github.com/tushev/aojdk-updatewatcher/wiki/Using-%22Most-recent%22-feature

@maverick74
Copy link
Author

maverick74 commented Sep 28, 2020

@tushev Great news!!! :)

I've also liked that it allows us to download the aojdk from the program :) (we´ll talk more about this bellow...)

  1. About the program, i think i found a bug:

when i choose that i wanted to install a new instance, a new window pops-up and i get to choose, on the "Major Version" option, that i want the "Most Recent" version.
However, after it downloads and installs the desired software version, the update software assumes the value "15" instead of "Most Recent". When version 16 get's out will it update?

  1. A suggestion about the wonderful option to get aojdk from the software:

Would be great that Either during the install process it would detect if there's no aojdk and offer to install it OR do this on the first run of the program, without one needing to go to the configurations screen and click on "Download and install".

@tushev
Copy link
Owner

tushev commented Sep 28, 2020

@maverick74 , "it's not a bug, it's a feature" :) (c)

Actually, the app behaves like intended. It discovers aojdk from the registry and applies default settings, which means staying on Branch 15.

"Always upgrade to most recent" is a non-standard (even potentially dangerous and compatibility breaking) feature, so the user must explicitly opt-in. To do so, you should explicitly override auto-discovered settings, as suggested here: https://github.com/tushev/aojdk-updatewatcher/wiki/Using-%22Most-recent%22-feature.

(So the answer to question 1 is no, it will not update unless you explicitly allow it).

I agree that there may be a little misunderstanding from the UX perspective: the user downloads "most recent" JRE and expects it to keep updating as "most recent branch". However, some other user may download "just the latest" JRE, but does not expect that suddenly one day JRE updates to next branch and possibly breaks compatibility. The app always stays on the safe side, as recommended by Java community guidelines. (BTW, their general recommendation is Stay on the latest LTS).

Maybe I should add a little clarification about this in UI&help.

Would be great that Either during the install process it would detect if there's no aojdk and offer to install it OR do this on the first run of the program, without one needing to go to the configurations screen and click on "Download and install".

Thank you for your suggestion! The app will always open configuration screen on fresh install (not upgrade), so the user will not miss it. As for install process option, I should see whether it's possible to add it.

@maverick74
Copy link
Author

@maverick74 , "it's not a bug, it's a feature" :) (c)

Actually, the app behaves like intended. It discovers aojdk from the registry and applies default settings, which means staying on Branch 15.

"Always upgrade to most recent" is a non-standard (even potentially dangerous and compatibility breaking) feature, so the user must explicitly opt-in. To do so, you should explicitly override auto-discovered settings, as suggested here: https://github.com/tushev/aojdk-updatewatcher/wiki/Using-%22Most-recent%22-feature.

I agree that there may be a little misunderstanding from the UX perspective: the user downloads "most recent" JRE and expects it to keep updating as "most recent branch". However, some other user may download "just the latest" JRE, but does not expect that suddenly one day JRE updates to next branch and possibly breaks compatibility. The app always stays on the safe side, as recommended by Java community guidelines.

Maybe I should add a little clarification about this in UI&help.

I see... Its better your way, no doubt! And how about an opt-in checkbox to "always keep on this branch" when user chooses the branch?

It plays the safe side but lets users choose to keep on the latest version...

Would be great that Either during the install process it would detect if there's no aojdk and offer to install it OR do this on the first run of the program, without one needing to go to the configurations screen and click on "Download and install".

Thank you for your suggestion! The app will always open configuration screen on fresh install (not upgrade), so the user will not miss it. As for install process option, I should see whether it's possible to add it.

Nice :)

@tushev
Copy link
Owner

tushev commented Sep 29, 2020

And how about an opt-in checkbox to "always keep on this branch" when user chooses the branch?

Nice idea, but I'm afraid it could be rather hard to implement: to do it, the app should somehow "track" the actions of MSI being currently installed and get its result installation path to create a manual override. AFAIK, there is no easy way to do it. As well, the path could be changed by user during installation process, + MSI usually uninstalls previous version, user can download and install several MSIs at once - this all complicates things a little for just one checkbox :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants