Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't explicitly reference global jQuery #10039

Merged
merged 1 commit into from
Nov 6, 2013
Merged

Conversation

daguej
Copy link
Contributor

@daguej daguej commented Aug 22, 2013

Removes window.jQuery in favor of jQuery, fixes #10038

Removes `window.jQuery` in favor of `jQuery`, fixes twbs#10038
@saas786
Copy link
Contributor

saas786 commented Aug 25, 2013

@daguej issue #10038 makes sense.

I have used multiple jQuery versions in several projects, and yes you are gonna say update your scripts to latest versions so they work with single version (the latest).

I know it becomes hard to maintain multiple versions, but there are situations you have to use multiple versions (you know it too I know), when we are dependent upon vital jQuery plugin which hasn't been updated (for whatever reasons) to work with latest version.

So I think it won't hurt using jQuery instead of current window.jQuery as they all means same (in my experience)

window.jQuery = window.$ = jQuery;

and as far as impact on Bootstrap code is concerned I see none (unless you point out any, so we can find a better solution).

So my 👍 for this change.

@fat, @mdo & @cvrebert please review and merge if no obvious conflict is present.

@cvrebert
Copy link
Collaborator

JS is fat's domain, so don't bother asking myself or mdo.

@saas786
Copy link
Contributor

saas786 commented Aug 27, 2013

@fat any comments?

@leog
Copy link

leog commented Sep 29, 2013

Waiting some news on this. We are waiting for you @fat :)

cvrebert added a commit that referenced this pull request Nov 6, 2013
Don't explicitly reference global jQuery
@cvrebert cvrebert merged commit f1b0cd4 into twbs:master Nov 6, 2013
@cvrebert
Copy link
Collaborator

cvrebert commented Nov 6, 2013

Sorry for the delay folks.

@juthilo
Copy link
Collaborator

juthilo commented Nov 7, 2013

@daguej: Do you give your permission to change Bootstrap's license to the MIT license? You can simply reply here. Thanks in advance!

@daguej
Copy link
Contributor Author

daguej commented Nov 8, 2013

@juthilo, good with me.

@juthilo
Copy link
Collaborator

juthilo commented Nov 8, 2013

@daguej Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootstrap JS incompatible with noConflict(true) jQuery
5 participants