Changed the index to be >= 0 to add offset/push/pull-0 #11295
Conversation
erikflowers
commented
Oct 30, 2013
erikflowers
commented
- Changed the index to be greater than or equal to zero so that offset-0, push-0, and pull-0 get added to the css file for html usage as "col-md-offset-0" to reset the offset/push/pull if you want to go from something that isn't zero, back to zero. This was changed from 3.0.0 apparently, as with 3.0.1 you can't uses these classes in HTML. You can generate the same effect on a class through less mixins like ".make-sm-column-offset(0)", but if using just bootstrap.css there was no way to reset them back to 0.
…t-0, push-0, and pull-0 get added to the css file for html usage as "col-md-offset-0" to reset the offset/push/pull if you want to go from something that isn't zero, back to zero.
|
Please run |
…t adds the zero-value offset/pull/push, but also adds a col-*-0, which is useless.
|
The idea works for un-offsetting/pulling/pushing something, but I think the bootstrap guys would have to decide if/how they wanted to output that as excluding the columns themselves, I am not sure I can figure out. |
|
Building on Erik's change, a potential resolution to get rid of col-*-0, we can add this change: I edited mixins.less and added an additional condition to the .calc-grid mixin. This has Erik's change on Line 775 as well. Here are the grunt dist results. |
…a zero value, but lets the offset, push, and pull have them as expcted.
|
Fixes #11328. |
|
I ended up doing this manually because of the number of master merges in this PR. Thanks for doing this though, it's in 3.0.2 which should drop this afternoon. |
|
Great! I so wanted the official contribution though. Print it out and put it on my fridge. Can I like change one character somewhere =D |
…(e.g., .col-md-offset-0)
…(e.g., .col-md-offset-0)
