Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better hover/active customization in button mixin #21037

Closed
mdo opened this issue Oct 28, 2016 · 2 comments
Closed

Better hover/active customization in button mixin #21037

mdo opened this issue Oct 28, 2016 · 2 comments
Labels

Comments

@mdo
Copy link
Member

mdo commented Oct 28, 2016

See #19414.

Ideally we could do better than a specific darken/lighten value.

@sqal
Copy link
Contributor

sqal commented Jun 15, 2017

Ideally we could do better than a specific darken/lighten value.

If I may throw an idea out here. Perhaps we can use sass maps to define buttons styles?:

$buttons: (
  primary: (
    color: $white,
    background-color: $brand-primary,
    border-color: $brand-primary,
    hover-color: $white,
    hover-background-color: darken($brand-primary, 20%)
    hover-border-color: null // if not defined, fallback to border-color ? 
  ),
  outline-primary: ()  
  ...
)

Wouldn't it be more flexible? Because sometimes apart from the usual color change, I would also like to add other button types or remove those I don't need at all in my project. What you think? :)

@roooodcastro roooodcastro mentioned this issue Jun 19, 2017
5 tasks
@mdo mdo removed this from the v4.0.0-beta milestone Jun 30, 2017
@mdo
Copy link
Member Author

mdo commented Jul 2, 2017

Dupe of #19353.

@mdo mdo closed this as completed Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants