Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using hex values for form state and alert colors #22175

Closed
oktalk opened this issue Mar 13, 2017 · 0 comments
Closed

Stop using hex values for form state and alert colors #22175

oktalk opened this issue Mar 13, 2017 · 0 comments

Comments

@oktalk
Copy link

oktalk commented Mar 13, 2017

Color definitions for form states and alerts should derive from the 'general variable structure' where all other colors are defined.

As often as we can, we should follow our convention of defining values off of our base variables. So for instance, state-success, state-info, state-warning, etc. should all modify the base value of brand-success, brand-info, brand-warning, etc. To ovoid creating new colors.

The Bootstrap framework should take the position of not assuming too much. Bootstrap should not assume that your form state and alert colors would differ from your established brand colors (as most instances they wouldn't). This would lighten the initial configuration of Bootstrap.

The following is a bad practice. It defines new colors outside of our main color definitions, and makes configuration more cumbersome:

$state-success-text:             #3c763d !default;
$state-success-bg:               #dff0d8 !default;
$state-success-border:           darken($state-success-bg, 5%) !default;

Instead we should have something like the following:

$state-success-text:             invert($brand-success) !default;
$state-success-bg:               darken($brand-success, 10) !default;
$state-success-border:           darken($state-success-bg, 5%) !default;
@oktalk oktalk changed the title Stop using hex values for stat color Stop using hex values for form state and alert color Mar 13, 2017
@oktalk oktalk changed the title Stop using hex values for form state and alert color Stop using hex values for form state and alert colors Mar 13, 2017
@mdo mdo mentioned this issue May 1, 2017
4 tasks
@mdo mdo mentioned this issue Jun 28, 2017
5 tasks
@mdo mdo added the has-pr label Jun 30, 2017
@mdo mdo added this to the v4.0.0-beta milestone Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants