Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textarea form feedback-icon position improvement [B4] #22670

Closed
IsaiahvH opened this issue May 21, 2017 · 1 comment
Closed

Textarea form feedback-icon position improvement [B4] #22670

IsaiahvH opened this issue May 21, 2017 · 1 comment
Labels

Comments

@IsaiahvH
Copy link

IsaiahvH commented May 21, 2017

Hi,

Maybe this is unnecessary or unwanted, but I propose the position of any feedback-control icon to be in the top right for any <textarea>s because the vertical center seems a weird position for the icon to be. The center position makes sense for normal fields, but for the textarea when spanning multiple rows, I think the top-right position would be an improvement.

I have created a Fiddle demonstrating this here.

It would require the inclusion of

textarea.form-control-success,
textarea.form-control-warning,
textarea.form-control-danger {
  background-position-y: ($input-height / 4);
}

This is a really minor improvement, but I thought I should try contributing wherever I can.

Kind regards,

Isaiah

@IsaiahvH IsaiahvH changed the title Textarea form feedback-icon position improvement Textarea form feedback-icon position improvement [B4] May 21, 2017
@mdo
Copy link
Member

mdo commented Jun 7, 2017

Closing for #22762.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants