Dropdown and detectNavbar

[danijelGombac]

Is there a reason why detectNavbar selector is not part of config options?

It could be an option like

data-navbar=".my-navbar"

Then the functionality could be extended to custom navbars.

[Johann-S]

Nope I just didn't handle that use case but we use the closest navbar

[danijelGombac]

It could be default '.navbar', but if someone need disable popper in custom navigation can use different selector to disable it.

[Johann-S]

This PR will allow you to disable Popper.js #24092

[danijelGombac]

Ok, thanks. I have another question. Why is used:

!$(parent).closest(Selector.NAVBAR_NAV).length

and not

!this._inNavbar

Is not the same? Navbar_nav should be inside navbar

[Johann-S]

Yep we can change that 👍

[Johann-S]

I think we can close this issue @danijelGombac ?

[danijelGombac]

Yes, thanks.