Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Margin utilities aren't included in bootstrap-grid.css #26371

Closed
Racso opened this issue Apr 24, 2018 · 3 comments
Closed

Margin utilities aren't included in bootstrap-grid.css #26371

Racso opened this issue Apr 24, 2018 · 3 comments

Comments

@Racso
Copy link

Racso commented Apr 24, 2018

Margin utilities such as ml-auto should be included in bootstrap-grid.css. They are even mentioned in the Grid System documentation, but right now, those examples don't work if you only include the Grid System.

Is there any reason why those aren't included with the Grid System?

@Johann-S
Copy link
Member

That's because bootstrap-grid is just our grid, and it would be strange to include other feature than our grid in this file.

/CC @andresgalante, @mdo

@Racso
Copy link
Author

Racso commented Apr 26, 2018

That makes sense, but let me back up a little to see if I'm making sense, too.

Right now, the grid has ways to create columns with a specific width (col-*) and columns with automatic width (col-auto). It also has ways to offset columns by a specific amount (offset-*). What I'm missing is a way to offset columns by automatic amounts (i.e. how to make an "automatic offset"). There's some kind of "feature asymmetry" in there.

I'm new to Bootstrap so I'm probably missing something, but I think that the "margin utilities" (maybe only the "auto" versions?) should be included with the grid. Right now, it feels to me that you can't deal effectively with columns with automatic width because you're lacking some tools in the grid file.

@mdo mdo added the feature label Jul 9, 2018
@mdo
Copy link
Member

mdo commented Jul 9, 2018

We can add these in for v4.2—we'll want them there for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants