Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation feedback icon issues #27142

Closed
ysds opened this issue Aug 28, 2018 · 13 comments
Closed

Validation feedback icon issues #27142

ysds opened this issue Aug 28, 2018 · 13 comments

Comments

@ysds
Copy link
Member

ysds commented Aug 28, 2018

I noticed that there are three issues about validation icon.

First issue:
The icon hides behind scrollbar when a textarea has very long text.

image

Second issue:
<select class="form-control"> show icon.

image

In the docs:

Background icons for <select>s are only available with .custom-select, and not .form-control.

and @mdo commented:

Only applies to textual inputs and textareas with .form-control and selects with .custom-select

but icon is appeared. That is expected?

Third issue:
<select class="custom-select" multiple> doesn't show icon.

image

All demo

@MartijnCuppens
Copy link
Member

I'm afraid this would be something we can't just fix with CSS.

@mdo
Copy link
Member

mdo commented Jan 14, 2019

Custom select without multiple attribute could maybe be fixed. Scrollbar on the <textarea> is tougher, too. And a multiple <select> is probably out too because it'd be hidden with a selected <option>'s background I think?

@ysds
Copy link
Member Author

ysds commented Jan 15, 2019

It is easy to remove the feedback icon of both <textarea> and multiple <select>. My only concern is consistency.

@mdo
Copy link
Member

mdo commented Jan 15, 2019

Yeah, I think the best bet here is to remove them for now. We can possibly revisit with a fresh approach in v5. Let me know if you have any thoughts on that @ysds.

@MartijnCuppens
Copy link
Member

I wouldn't remove it for <textarea> and <select> because this isn't an issue for MacOS.

@mdo
Copy link
Member

mdo commented Jan 15, 2019

Do we change the positioning then, or try some CSS hacks to target Windows?

@MartijnCuppens
Copy link
Member

Shifting the icon a bit to the left looks weird if the scrollbar is not present. I wouldn't go for CSS hacks for windows, since it is also possible to always show your scrollbar in mac (see for example: http://osxdaily.com/2011/08/03/show-scroll-bars-mac-os-x-lion/). Not sure how to continue with this one.

@pcodedviral
Copy link

just use given js in wich you need make diffrent background image for scrollble textarea

http://jsfiddle.net/qKNXH/

thanks.

@ysds
Copy link
Member Author

ysds commented Jan 23, 2019

I have no idea to solve this problem by CSS only while maintaining the current HTML structure. It would definitely requires a wrapper element.

@MartijnCuppens
Copy link
Member

@pcodedviral, our css should work independent of js, so we can't use those techniques, thanks though.

Like @ysds mentioned, I don't think there's a way to get control of this with our current HTML structure.

@mdo
Copy link
Member

mdo commented Jul 13, 2019

Thinking we close this as a won't/can't fi?. The select issue has been fixed in v5 with #28450 and there's still some improvement to be done there.

@MartijnCuppens
Copy link
Member

This is a can't fix indeed

@Ragavendhran-N
Copy link

Can't we just modify the background-position style to comfortable values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants