Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back .form-text #30477

Closed
MartijnCuppens opened this issue Mar 28, 2020 · 3 comments · Fixed by #30565
Closed

Bring back .form-text #30477

MartijnCuppens opened this issue Mar 28, 2020 · 3 comments · Fixed by #30565
Labels
css has-pr v5

Comments

@MartijnCuppens
Copy link
Member

In the notorious form updates PR (#28450), .form-text was dropped. I don't think that was the right thing to do, having a class which we can use to keep form descriptions consistent would help. We could also add some null variables (font size, font weight, font style, color) to make this element more more configurable.

Thoughts @twbs/css-review?
@MartijnCuppens MartijnCuppens mentioned this issue Mar 28, 2020
Closed
@zalog
Copy link
Contributor

zalog commented Mar 28, 2020 •
edited
Loading

Yep, and eventually be consistent with .*-feedback classes too.

Sorry, I just followed what @mdo started, but I think if we find a way to bring some consistency between .form-text and .*-feedback, it's a win.

@MartijnCuppens
Copy link
Member Author

I've asked @mdo about this on Slack and he's ok bringing .form-text back. Since we also did #30476, I think it makes sense to continue with this.

@zalog do you mind having a look at this, since you already did some research in #30397?

@zalog
Copy link
Contributor

zalog commented Apr 11, 2020

Yep, sure. I'm glad that I can help :)
I'll get back on it soon.

@zalog zalog mentioned this issue Apr 12, 2020
Merged
@mdo mdo added the has-pr label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css has-pr v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adds back .form-text zalog/bootstrap
3 participants
@mdo @zalog @MartijnCuppens