Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make our bundle SSR friendly #34265

Open
alpadev opened this issue Jun 15, 2021 · 4 comments
Open

Make our bundle SSR friendly #34265

alpadev opened this issue Jun 15, 2021 · 4 comments
Labels
build feature js p4 Low priority, nice to have

Comments

@alpadev
Copy link
Contributor

alpadev commented Jun 15, 2021

Creating this issue so we don't forget about this.

Idea taken from #33131

@axelthat
Copy link

Any updates?

@TCB13
Copy link

TCB13 commented Apr 13, 2023

There's this PR here #34989

@yharaskrik
Copy link

Is there anything I can do to help move this along? It seems like it was attempted in both #34989 and #38460 but ultimately did not make it in.

We are using SSR with Angular and need to manually init domino so that SSR works with bootstrap, if one of the maintainers has some direction I can take a stab at this, or if it just essentially just following the same steps as #34989 then I can do that as well.

@TCB13
Copy link

TCB13 commented Aug 17, 2023

Is there anything I can do to help move this along? It seems like it was attempted in both #34989 and #38460 but ultimately did not make it in.

Maybe you can take my PR #38460 and try to merge master into it and see how it goes / fix whatever needs fixing and create a new PR?

What I don't get about this is that multiple people have been trying to push solutions and it now seems like a bikeshed color situation.

Site note: I've used my PR in production and with that specific version everything works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build feature js p4 Low priority, nice to have
Projects
None yet
Development

No branches or pull requests

4 participants