From f05bd63d8e829334036c4eadef4e01e79374cae7 Mon Sep 17 00:00:00 2001 From: Chirag Modi Date: Mon, 17 Jul 2017 13:29:49 +0530 Subject: [PATCH 1/3] fixed issue #23100 --- scss/_variables.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/scss/_variables.scss b/scss/_variables.scss index f0949eaffead..21c96b5d24ae 100644 --- a/scss/_variables.scss +++ b/scss/_variables.scss @@ -189,6 +189,7 @@ $grid-breakpoints: ( // Define the maximum width of `.container` for different screen sizes. $container-max-widths: ( + xs: 100%, sm: 540px, md: 720px, lg: 960px, From a52a1fbb13a908f4b0eca9671436f325fb45a61b Mon Sep 17 00:00:00 2001 From: Chirag Modi Date: Tue, 18 Jul 2017 11:44:56 +0530 Subject: [PATCH 2/3] remove change which set from variable and make those in container class --- scss/_variables.scss | 1 - scss/mixins/_grid.scss | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/scss/_variables.scss b/scss/_variables.scss index 21c96b5d24ae..f0949eaffead 100644 --- a/scss/_variables.scss +++ b/scss/_variables.scss @@ -189,7 +189,6 @@ $grid-breakpoints: ( // Define the maximum width of `.container` for different screen sizes. $container-max-widths: ( - xs: 100%, sm: 540px, md: 720px, lg: 960px, diff --git a/scss/mixins/_grid.scss b/scss/mixins/_grid.scss index 5c00f57d76a0..b7d4427496e0 100644 --- a/scss/mixins/_grid.scss +++ b/scss/mixins/_grid.scss @@ -7,6 +7,7 @@ margin-left: auto; padding-right: ($grid-gutter-width / 2); padding-left: ($grid-gutter-width / 2); + width: 100%; } From b2712048ce0b49188f644742577056096205656e Mon Sep 17 00:00:00 2001 From: Chirag Modi Date: Tue, 18 Jul 2017 11:48:59 +0530 Subject: [PATCH 3/3] make changes as per suggestion in #23100 --- scss/mixins/_grid.scss | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scss/mixins/_grid.scss b/scss/mixins/_grid.scss index b7d4427496e0..67dbcd38ece9 100644 --- a/scss/mixins/_grid.scss +++ b/scss/mixins/_grid.scss @@ -15,8 +15,7 @@ @mixin make-container-max-widths($max-widths: $container-max-widths, $breakpoints: $grid-breakpoints) { @each $breakpoint, $container-max-width in $max-widths { @include media-breakpoint-up($breakpoint, $breakpoints) { - width: $container-max-width; - max-width: 100%; + max-width: $container-max-width; } } }