Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate generated icons #1639

Closed
XhmikosR opened this issue Mar 25, 2023 · 1 comment · Fixed by #1521
Closed

Duplicate generated icons #1639

XhmikosR opened this issue Mar 25, 2023 · 1 comment · Fixed by #1521
Labels
bug Something isn't working build help wanted Extra attention is needed

Comments

@XhmikosR
Copy link
Member

XhmikosR commented Mar 25, 2023 •
edited
Loading

It seems the issue stems from us using the previous codepoints. If I remove it, then the generated assets are the correct, but the codepoints have obviously changed.

We should try to fix it in our https://github.com/twbs/fantasticon fork and I try making an upstream PR later along with the other changes.

Any PRs are more than welcome in our fork :)

Refs #1521
@XhmikosR XhmikosR added bug Something isn't working help wanted Extra attention is needed build labels Mar 25, 2023
@XhmikosR XhmikosR mentioned this issue Mar 25, 2023
Merged
@XhmikosR
Copy link
Member Author

NVM, it seems we had those duplicate icons in bootstrap-icons.json so we were adding them back every time we build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working build help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove non-existent icons from font stefan-korn/icons
1 participant
@XhmikosR