Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The benchmark typecheck-nixpkgs-lib does not run #836

Closed
Acaccia opened this issue Sep 16, 2022 · 2 comments · Fixed by #840
Closed

The benchmark typecheck-nixpkgs-lib does not run #836

Acaccia opened this issue Sep 16, 2022 · 2 comments · Fixed by #840

Comments

@Acaccia
Copy link
Contributor

Acaccia commented Sep 16, 2022

Describe the bug
As of now, there is a parsing error in the Nickel program used for this benchmark:

UnexpectedToken(RawSpan { src_id: FileId(8), start: ByteIndex(6569), end: ByteIndex(6577) }, ["\"\\\"\"", "\"..\"", "\";\"", "\"identifier\"", "\"m%\\\"\"", "\"}\""])] }'

To Reproduce
cargo bench --bench=typecheck-nixpkgs-lib

Expected behavior
The benchmark should run without issue.

Environment

@yannham
Copy link
Member

yannham commented Sep 19, 2022

Ah, #829 introduced a new keyword "optional", so the function with the same name causes a parse error. In the future we may want to parse metadata in a nicer way, without reserving tens of keywords, but for the time being, let's just rename this one.

@yannham
Copy link
Member

yannham commented Sep 19, 2022

Sorry, I meant #815, not 829.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants