Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure all labels we use in rules_haskell are fully qualified #726

Closed
nmattia opened this issue Mar 5, 2019 · 5 comments
Closed

Make sure all labels we use in rules_haskell are fully qualified #726

nmattia opened this issue Mar 5, 2019 · 5 comments
Labels

Comments

@nmattia
Copy link
Contributor

nmattia commented Mar 5, 2019

Last week I got bitten by rules_haskell's assumption that a ./haskell/ directory exists and contains a ghc.BUILD (see #719 (comment)). Most likely this is only the case in the root of this repo. I suspect there are a few similar bugs lurking around.

One way to make sure that we don't make such assumptions is to have tests be run from a different directory.

CC @Profpatsch

@mboes
Copy link
Member

mboes commented Mar 9, 2019

You mean from a dependent project. Please update title and description accordingly. I think we should do better than this: detect all hard-coded labels and make sure they are all fully qualified.

@Profpatsch Profpatsch changed the title Run tests outside of ./. to ensure reproducibility Make sure all labels we use in rules_haskell are fully qualified Oct 7, 2019
@Profpatsch
Copy link
Contributor

detect all hard-coded labels and make sure they are all fully qualified.

What kind of labels are problematic for outside projects?

@mboes
Copy link
Member

mboes commented Apr 6, 2021

It's unclear that this still an issue. See bazelbuild/bazel#7130.

@ylecornec
Copy link
Member

Indeed, it seems that within the main repository, // at the start of labels should now be equivalent to @rules_haskell//.

@mboes
Copy link
Member

mboes commented Apr 6, 2021

OK let's close then.

@mboes mboes closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants