-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network quality level for main participant #490
Comments
Hi @coreymaher - thanks for bringing this to our attention! You are correct - there is no NetworkQualityLevel component for the Main Participant, and there isn't any reason why the Main Participant can't have one. So we added a ticket to our backlog to address this. It's a pretty easy fix, so I'd expect to see a pull request in a week or two to get this fixed. Thanks again! |
Thanks for looking into this for me @timmydoza! |
Hi @coreymaher! This fix has been merged into the |
Great, thanks @olipyskoty! |
Question
I was looking through the network quality level logic and noticed that the
NetworkQualityLevel
component only seems to be used in theParticipantInfo
component and not in theMainParticipantInfo
component. Unless I'm missing something, this means you can't see the network quality level on the main participant. Is there a reason we can't, or wouldn't want to, display the network quality on the main participant?Additional context
See https://github.com/twilio/twilio-video-app-react/blob/master/src/components/MainParticipantInfo/MainParticipantInfo.tsx#L111 vs https://github.com/twilio/twilio-video-app-react/blob/master/src/components/ParticipantInfo/ParticipantInfo.tsx#L182
The text was updated successfully, but these errors were encountered: