Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network quality level for main participant #490

Closed
coreymaher opened this issue Apr 13, 2021 · 4 comments
Closed

Network quality level for main participant #490

coreymaher opened this issue Apr 13, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@coreymaher
Copy link

Question
I was looking through the network quality level logic and noticed that the NetworkQualityLevel component only seems to be used in the ParticipantInfo component and not in the MainParticipantInfo component. Unless I'm missing something, this means you can't see the network quality level on the main participant. Is there a reason we can't, or wouldn't want to, display the network quality on the main participant?

Additional context
See https://github.com/twilio/twilio-video-app-react/blob/master/src/components/MainParticipantInfo/MainParticipantInfo.tsx#L111 vs https://github.com/twilio/twilio-video-app-react/blob/master/src/components/ParticipantInfo/ParticipantInfo.tsx#L182

@coreymaher coreymaher added the question Further information is requested label Apr 13, 2021
@timmydoza
Copy link
Contributor

Hi @coreymaher - thanks for bringing this to our attention!

You are correct - there is no NetworkQualityLevel component for the Main Participant, and there isn't any reason why the Main Participant can't have one. So we added a ticket to our backlog to address this. It's a pretty easy fix, so I'd expect to see a pull request in a week or two to get this fixed.

Thanks again!

@timmydoza timmydoza added bug Something isn't working and removed question Further information is requested labels Apr 14, 2021
@coreymaher
Copy link
Author

Thanks for looking into this for me @timmydoza!

@olipyskoty
Copy link
Contributor

Hi @coreymaher! This fix has been merged into the master branch. Please let us know if you have any questions or run into any issues! 🙂

@coreymaher
Copy link
Author

Great, thanks @olipyskoty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants