Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitkeep as one of default valid filenames #643

Closed
stevepiercy opened this issue Aug 2, 2024 · 2 comments · Fixed by #647 or plone/volto#6232
Closed

Add .gitkeep as one of default valid filenames #643

stevepiercy opened this issue Aug 2, 2024 · 2 comments · Fixed by #647 or plone/volto#6232

Comments

@stevepiercy
Copy link
Contributor

With the change from #622, a very common filename .gitkeep was omitted from the list of valid filenames.

Would you please consider adding the filename .gitkeep to the list at https://github.com/MetRonnie/towncrier/blob/9b685033b22bd3ee1bd81955a333e0e20bef02e6/src/towncrier/_builder.py#L117?

I would be happy to submit a PR to save myself several hours of work to modify our repositories in the Plone organization alone.

Thank you for your consideration.

Ref plone/volto#6225

@adiroiban
Copy link
Member

Thanks for report.

Yes. I would be happy to have it to the list.

@stevepiercy
Copy link
Contributor Author

@adiroiban PR added: #647. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants