-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc-gen-twirp generates non stable imports list #298
Comments
I think you refer to the order of imports being unreliable each time that the code is generated right? That could be fixed by converting the map into a list and sorting it. What do you think? |
Thanks for the reply. Yes, non-stable order of imports is what I meant. I actually forked and patched using the same way as your suggestion
, but I have some trouble to come up a test input for |
@marioizquierdo I sent the PR, but I don't really know how to write the test case for that PR. Any example I could look at? |
Fixed by #312 |
If the protobuf definition has more than one imports, the generated code may change due to iterate over a map https://github.com/twitchtv/twirp/blob/master/protoc-gen-twirp/generator.go#L340-L342 .
This is an issue because we check in generated codes, and it keeps changing making our CI think someone forgot to check in the generated codes.
The text was updated successfully, but these errors were encountered: