make Bufferable collections safer #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -222,50 +223,41 @@ object Bufferable extends GeneratedTupleBufferable with Serializable { | |||
| val nextBb = reallocatingPut(bb){ _.putInt(size) } | |||
| l.foldLeft(nextBb) { (oldbb, t) => reallocatingPut(oldbb) { buf.put(_, t) } } | |||
| } | |||
| // Assumes the builder passed in was just created from a CanBuildFrom | |||
There was a problem hiding this comment.
Is this touched on heavily outside of bijection itself? -- cleaner to just break the api if its not being used much? Or is it?
There was a problem hiding this comment.
I doubt seriously anyone is using it on earth other than below in this file. Fix now?
There was a problem hiding this comment.
I think so, lets just get it out of the way, incase someone starts... :)
|
closes #149 |
ianoc
added a commit
that referenced
this pull request
Nov 14, 2013
make Bufferable collections safer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.