Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build is failing icon #222

Closed
0xABAB opened this issue Mar 11, 2016 · 8 comments
Closed

Build is failing icon #222

0xABAB opened this issue Mar 11, 2016 · 8 comments

Comments

@0xABAB
Copy link

0xABAB commented Mar 11, 2016

You use some CI tool which shows that the build is failing. Either remove the icon or fix the problem.

@mosesn
Copy link
Contributor

mosesn commented Mar 11, 2016

@0xABAB welcome to the scrooge community! Good catch, would you like your first contribution to be helping us understand why it failed and fixing it? Looking around at the logs, it looks like sbt can't find the main method anymore. I think this would be a great way for you to join the community 😻

@0xABAB
Copy link
Author

0xABAB commented Mar 12, 2016

Uhm, if your software falls apart, you just have to hire more people, not beg for other people to fix your issues.

I am more than capable of fixing any software issue, but that doesn't mean I have a high interest in fixing your software.

I think it's a rather pathetic statement for a company like Twitter. It makes Twitter look weak. I wouldn't want to be associated with beggars.

@mosesn
Copy link
Contributor

mosesn commented Mar 12, 2016

Hi @0xABAB, Twitter is a microblogging website, and open sources its tools because it wants to give back to the community. We don't work for you, and we have limited bandwidth. Demanding that we do something, or being rude will not help either of us. While you're participating in the twitter open source community, please follow the Twitter code of conduct.

@yschimke
Copy link

@0xABAB I'm with you, some of us have lower tolerance for such shoddy work. I can't unsee this now you pointed it out!

I installed the Stylebot chrome extension after you pointed out this problem, and the following script will hide this icon. I realise you could have done this yourself, but we should share our small victories.

img[data-canonical-src="https://travis-ci.org/twitter/scrooge.svg?branch=develop"] {
    display: none;
}

https://chrome.google.com/webstore/detail/stylebot/oiaejidbmkiecgbjeifoejpgmdaleoha/related?hl=en

I hope this helps, maybe @mosesn could agree at least update this thread after they finally fix the build and then we can both remove this workaround.

@0xABAB
Copy link
Author

0xABAB commented Mar 13, 2016

Twitter is a microblogging website, and open sources its tools because it wants to give back to the community.

Man, you are killing me. That's just hilarious. Twitter has a self-interest in getting more people to work with their code and tools; that is why it is open-sourced. Not because Twitter believes in some culture of sharing (it would have been a foundation, not a company in that case). It would be "giving back", if no contribution from the community had ever been done, because it was already perfect at release time. Any contribution back from the community, makes it a more symbiotic relation at first, but the very first bug fixed by the community is just pure profit. The very fact that I pointed out this issue, is something a PM would normally do; a PM you would normally have to pay.

Demanding that we do something, or being rude will not help either of us.

I don't demand anything. I just say which work needs to be done. Who actually does it is of no concern to me. I have my reasons for opening issues in projects I am considering to use. Whether or not it actually gets fixed is hardly of interest to me. What is important is the amount of drama involved. In this case the drama is so high (perhaps you are micro-blogging all day long, which makes you good at drama, but made you forget about your job). That would be a reason for me (and hopefully others) to never start using this software in the first place (which is, of course, the direct opposite of your corporate goals). Isn't this multi-agent game called "open-source"-development fun?

While you're participating in the twitter open source community, please follow the Twitter code of conduct.

Oh man, you really lack any kind of social insight, right? I also believe you don't know the meaning of the word "community".

@yschimke I have little interest in stylistic improvements, but I do appreciate your efforts (with the exception of your voting bullshit).

As far as the rest of these clowns down voting, please grow a spine.

@TwitterHQ: please hire some more competent people next time. These people are destroying your brand (or whatever is left of it).

@twitter twitter locked and limited conversation to collaborators Mar 13, 2016
@mosesn
Copy link
Contributor

mosesn commented May 29, 2016

The build passes, so I'm going to mark this as fixed.

@mosesn mosesn closed this as completed May 29, 2016
@taylorleese
Copy link
Contributor

It's actually failing again. https://travis-ci.org/twitter/scrooge/builds

@taylorleese taylorleese reopened this Jun 1, 2016
@mosesn
Copy link
Contributor

mosesn commented Oct 3, 2016

The build has been passing pretty consistently: https://travis-ci.org/twitter/scrooge/builds

@mosesn mosesn closed this as completed Oct 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants