WIP: fix numba version dependency error #1186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwartell
changed the title
|
The ImportError is being raised by numba _ensure_critical_deps https://github.com/numba/numba/blob/8e6fa5690fbe4138abf69263363be85987891e8b/numba/__init__.py#L125 |
well actually the import is weird: import tensorflow_datasets.public_api as tdfs which violates established convention is this a TODO?
I'm trying to fix a dependency error, but this load of a missing file is breaking the test before the fault is reached
|
Fixed by #1181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a numba version violation in a transitive dependecy in pytorch on numba.
Fixes #1183. Related to #1175.