Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm greyscale / color support in EPDLib doesn't break PaperPi #37

Closed
9 tasks
aaronr8684 opened this issue Mar 17, 2022 · 9 comments
Closed
9 tasks
Assignees
Labels
question Further information is requested

Comments

@aaronr8684
Copy link
Collaborator

aaronr8684 commented Mar 17, 2022

Confirm grey and color support

  • Pending EPDLib publishing to PyPi
  • Test install process (32/64)
  • Confirm multiple screens

Screens/modes tested:

  • 2.13 BW
  • 3.7 BW
  • 4.2 BW
  • 5.65 BW
  • 7.5 BW
  • IT8951 9.7in Grayscale
@aaronr8684 aaronr8684 added this to the Add Omni EPD support milestone Mar 17, 2022
@aaronr8684 aaronr8684 self-assigned this Mar 17, 2022
@aaronr8684 aaronr8684 added enhancement New feature or request question Further information is requested and removed enhancement New feature or request labels Mar 17, 2022
@txoof
Copy link
Owner

txoof commented Mar 17, 2022

@aaronr8684 modified epdlib works, but breaks grayscale support in paperpi for IT8951

Also need to update the documentation for the format for display_type in the configuration.

@txoof
Copy link
Owner

txoof commented Mar 17, 2022

Also, splash screen doesn't appear and nothing displays until the first plugin is loaded. I suspect this is related to the bug you noticed in #35. This error cropped up immediately after moving to epdlib 0.6.

@aaronr8684
Copy link
Collaborator Author

Ok. I figured greyscale was likely broken because of the combined logic, but will be fixed in the next update with color support.

@aaronr8684
Copy link
Collaborator Author

Also, splash screen doesn't appear and nothing displays until the first plugin is loaded. I suspect this is related to the bug you noticed in #35. This error cropped up immediately after moving to epdlib 0.6.

Splash works fine for me on the 7.5b screen, let me try on the 4.2 with the correct config.

@txoof
Copy link
Owner

txoof commented Mar 17, 2022

looking forward to that. I think the logic in paperpi will probably need some help too for grayscale.

I think the problem is located in paperpi.py. If "HD" isn't in display_type, it passes the force_onebit param to the Plugin object.

            # force layout to one-bit mode for non-HD screens
            if not config['main'].get('display_type') == 'HD':
                plugin_config['force_onebit'] = True

We could just fudge it and set force_onebit=False for all cases and see what happens :)

@aaronr8684
Copy link
Collaborator Author

looking forward to that. I think the logic in paperpi will probably need some help too for grayscale.

Yea absolutely (and for color). I'm still thinking how we could allow for color support but also default to BW if nothing is specified. I'm thinking the default logic will stay in EPDLib (for back support) and the various modes can be specified in PaperPi if needed.

We could just fudge it and set force_onebit=False for all cases and see what happens :)

or just change the logic to if 'it8951' not in config['main'].get('display_type'):

That's the same logic I used (but without the 'not') in EPDLib for the time being to prompt for a VCOM

@aaronr8684
Copy link
Collaborator Author

I also made one change to the image mode in the EPDLib that might help re-enable greyscale.

@aaronr8684
Copy link
Collaborator Author

4.2c splash works as expected with the correct config

@txoof
Copy link
Owner

txoof commented Jun 19, 2023

I've merged in RGB support without OMNI EPD #79

@txoof txoof closed this as completed Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants