feat: Add native scripts #241
Conversation
|
@SmaugPool this is great! A feature much overdue. One question though, any particular reason you're using camelCase for the event record fields? Is it a hard requirement? We're using snake_case for the rest of the records, would be nice to maintain the same convention across the board. |
| @@ -228,6 +232,19 @@ impl EventWriter { | |||
| self.append(EventData::BlockEnd(record))?; | |||
| } | |||
|
|
|||
| for witness in block.transaction_witness_sets.iter() { | |||
There was a problem hiding this comment.
Maybe we would like to allow to distinguish witnesses scripts from auxiliary data ones?
Yes, this is needed to rebuild the script exactly in its original format, see my comment here: https://github.com/txpipe/oura/pull/241/files#r846800039 And notice how Cardano SImple scripts use camel case: Thanks to this serialization format, running I don't think it goes against Oura convention, I just consider it as a Cardano object & format and not an Oura one. |
|
I think the camelCase is fine. It's an appropriate usage of serde's rename all |
|
@SmaugPool please flag me when you consider the PR ready for review / merge. LGTM, but I'm not sure if you consider it done. |
@scarmuega It's ready from my point of view. I will also release version 1.0.0 of my sink as soon as an Oura release includes native scripts. |
This is used by https://github.com/SmaugPool/oura-script-sink to make all minting policies available on pool.pm.
I'm not sure if we would like to be able to distinguish scripts coming from witnesses from those coming from auxiliary data.
For now this is not the case.