Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excludeKeys not working #42

Closed
sroutier opened this issue Feb 1, 2017 · 2 comments
Closed

excludeKeys not working #42

sroutier opened this issue Feb 1, 2017 · 2 comments

Comments

@sroutier
Copy link
Contributor

sroutier commented Feb 1, 2017

The config record.excludeKeys is not working properly.

The method Recorder.getData():

    protected function getData() {
        $data = Input::all();
        if (is_array($data)) {
            $this->excludeKeys($data);
            return $data;
        } else {
            return null;
        }
    }

Return the unmodified/unfiltered $data array instead of returning the array modified by Recorder.excludeKeys(...)

PR on its way.

@tylercd100
Copy link
Owner

Version 3.7.5 has this fix

@sroutier
Copy link
Contributor Author

sroutier commented Feb 1, 2017

Cool, it's fixed thank you but I can't use it.
I'll open a new issue.
/s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants